Bhavya-Sonigra opened a new pull request, #6267:
URL: https://github.com/apache/fineract/pull/6267
## Description
This PR fixes an issue where cash refunds for active loans configured with
accrual accounting were incorrectly debiting `INCOME` accounts instead of
`RECEIVABLE` accounts (treating active loan refunds under cash-based logic).
**Root Cause:**
In `AccrualBasedAccountingProcessorForLoan.java`,
`createJournalEntriesForRefundForActiveLoan` was incorrectly referencing
`INCOME_FROM_FEES`, `INCOME_FROM_PENALTIES`, and `INTEREST_ON_LOANS`.
**Changes Made:**
Updated the method to correctly map the credit entries to their respective
`RECEIVABLE` account types (`FEES_RECEIVABLE`, `PENALTIES_RECEIVABLE`,
`INTEREST_RECEIVABLE`). Verified locally by provisioning an active accrual
loan, overpaying a fee, and issuing a refund, ensuring the General Ledger
correctly routes the credit to `ASSET` instead of `INCOME`.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [x] Write the commit message as per our guidelines
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [x] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made. *(Note: Fix verified against existing accrual integration tests)*
- [x] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [x] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
