adamsaghy commented on code in PR #6228:
URL: https://github.com/apache/fineract/pull/6228#discussion_r3782570044
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/filters/IdempotencyStoreFilter.java:
##########
@@ -68,6 +73,33 @@ protected void doFilterInternal(@NonNull HttpServletRequest
request, @NonNull Ht
}
}
+ private void warnIfIdempotencyKeyHeaderMissing(HttpServletRequest request)
{
Review Comment:
I dont really like this solution. It is full of duplicated conditions....
1. Lets use application property instead of database stored global
configuration -> We dont need to fetch this information from database for each
requests... it hits performance
2. Skip these extra checks and add the warning to the place where we read
the idempotency key from the request anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
