opensource-joe commented on PR #339: URL: https://github.com/apache/fineract-backoffice-ui/pull/339#issuecomment-5297688616
@Aman-Mittal Screenshots below. Every tab here is a real tab in one Chromium window, driven by this repo's own mocked-backend pattern (the `mocked` Playwright project), so none of it needs a Fineract instance to reproduce.  Row 1 is `main`: six different sections, six identical tabs. Row 2 is this branch. Row 3 is the same tabs after switching the header language selector to Korean, with no navigation in between, which is the re-apply on language change the commit message describes. That runtime switch, as title strings: ``` /clients: "Clients · Fineract" -> "고객 · Fineract" (url unchanged: true) /groups: "Groups · Fineract" -> "그룹 · Fineract" (url unchanged: true) /accounting: "Accounting · Fineract" -> "회계 · Fineract" (url unchanged: true) ``` One detail worth raising rather than leaving for you to spot: `app.shortTitle` exists only in `en.json`, so the `· Fineract` suffix surviving in the Korean tabs is `setFallbackLang('en')` doing its job, not an untranslated key reaching the tab. If you would rather that suffix be localised too, say the word and I will add the key to `hi.json` and `ko.json`. <details> <summary>Full-window captures</summary> Before, on `main`:  After, on this branch:  After, language switched to Korean at runtime:  </details> Working on the commit amend and the signature check next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
