Aman-Mittal commented on issue #232:
URL:
https://github.com/apache/fineract-backoffice-ui/issues/232#issuecomment-5303648959
Yes, please take it, and yes, splitting is fine — the issue is deliberately
scoped so several can be in flight. Calendars and meetings first, then the
rest, works. Just comment which files you are on when you start each batch so
nobody doubles up.
On the deletes — the honest answer is that the UI cannot tell you. Both
screens call `DELETE /v1/provisioningcategory/{categoryId}` and `DELETE
/v1/provisioningcriteria/{criteriaId}` and get back a
`CommandProcessingResult`; all the semantics live in the backend. My
understanding, which I would rather you verify than take from me: these are
hard deletes of the definition rows, and already-generated provisioning entries
are snapshots that are not recalculated — so what changes is the next
provisioning run, not how existing loans are already classified in what has
been reported. On the reference check, I believe the backend rejects deleting a
category that a criterion still points at, but I do not want to assert the
exact behaviour from memory. `ProvisioningCategoryWriteServiceImpl` and
`ProvisioningCriteriaWriteServiceImpl` in apache/fineract are the source of
truth, and trying it against a local instance will settle it in a minute.
Which leads to the one thing I would ask: **do not have the confirm message
claim a consequence we have not verified.** Better a factual message than a
confident wrong one. If the check turns out to be missing, that is worth its
own issue rather than expanding this PR — a line in the PR description pointing
at it is exactly right, and I would rather have the modal fix land clean.
Also, line numbers have drifted since I wrote this —
`calendars-list.component.ts` is at 142 now, not 128. Files are all still
correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
