opensource-joe commented on PR #365: URL: https://github.com/apache/fineract-backoffice-ui/pull/365#issuecomment-5305359917
@Aman-Mittal Would you be able to approve the workflow runs on this PR when you get a chance? All five (`CI`, `E2E Tests`, `CodeQL Advanced`, `Fineract Signed Commits Check`, and the zizmor security analysis) are sitting at `action_required` and none have executed, so nothing reports in the checks list. Worth flagging because that reads as CI simply not having started rather than as something waiting on a person. Not asking for a review yet, only for CI to be allowed to run, so any failures are mine to fix before I take up your time. For context on what is waiting: `lint`, `lint:prune` and `format:check` all exit 0 on this branch, and the unit suite is 962 of 962 against real headless Chromium, with the new `tooltip.directive.spec.ts` at 10 of 10 on its own. The piece I would most like CI's opinion on is the second commit, `scripts/check-a11y-names.mjs`, since it is a new build-time check wired into the `i18n-check` job and it is the one thing here that can fail somebody else's PR later. I tested it in both directions locally, exit 0 on this branch and exit 1 naming the file, line and fix when a single `[attr.aria-label]` is removed, but a check that gates other people deserves to be seen running in CI rather than taken on my word. On signing, since that check is in the list: the three commits are GPG-signed and GitHub reports `verified: true` on all three. An earlier attempt at this work was signed with SSH, which this repo's `verify-signed-commits.sh` correctly rejects, and those branches have been removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
