HurrairaBaloch opened a new pull request, #366: URL: https://github.com/apache/fineract-backoffice-ui/pull/366
## What and why Part of #232. Six remaining list screens still confirmed deletes with `window.confirm` — unstyled, English-only, and blocking. They now use `DialogService.confirm` like `codes-list`, with translated copy, `destructive: true`, and the delete skipped when the dialog resolves false. Calendars and meetings are left for @AmandaKeay as agreed. Confirm copy is factual (row name only). Provisioning messages do not claim unverified backend consequences; the account-number-format line notes that already issued identifiers keep their current shape. ## Verification - `npm run lint` - `npm run i18n:check` - Prettier on the touched files - `ng test` for the six list specs: 24/24 passing (including cancel does not call DELETE) - UI exercised against TestBed mocks, not a live Fineract backend ## Screenshots Not applicable — same list screens; only the confirm dialog implementation changed. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. (unit coverage of confirm/cancel; no e2e for these lists existed) - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
