Aman-Mittal commented on issue #123:
URL:
https://github.com/apache/fineract-backoffice-ui/issues/123#issuecomment-5306582491
#368 implements two of this epic's three sub-issues and part of the third.
- **#139 — action-specific permission hints.** Actions on the record in
front of the user are now
disabled with a 🔒 and *"Requires: APPROVE_LOAN — Approve loans"* on both
the tooltip and the
accessible name, rather than removed. 86 actions across loan, client,
group, centre and savings
detail screens. The one criterion not implemented is the ⏳ checker-mode
state: there is no
maker-checker signal on those screens to drive it, so it would have to be
invented.
- **#118 — `PermissionSummaryPipe`.** Codes to sentences, grouped by entity.
- **#138 — sidebar hints.** Two of three criteria; the third asks for
restricted entries to be
shown greyed with a "request this" hint, which contradicts the navigation
gating in #142 and
#368. Reasoning in a comment there.
- **#140 — "My Access" card.** Untouched: @paultofunmi is assigned and
picked it up.
**This epic stays open** while #138 and #140 do.
One thing worth recording against the epic as a whole, since it shaped how
the sub-issues were
implemented. "Permission feedback" pulls in two directions, and which one is
right depends on what
the control does rather than on how privileged it is:
- Something that **navigates elsewhere** — a nav entry, a Create button — is
removed. It is not a
destination for this user, and a corridor of greyed-out doors buries what
they *can* do. A
permission-less user seeing all 115 nav entries greyed is worse than
seeing four.
- An **action on the record already on screen** is disabled and labelled.
The user has committed to
this loan; that they cannot approve it is a fact about their role they
need to act on, and hiding
the button leaves them to conclude the feature does not exist.
The same rule explains the Access Denied page naming the permissions the
route wanted (#112): the
user committed to that URL, so the refusal owes them a reason. Applied
consistently, the epic's
goal — the user learns what to ask an administrator for — is met without a
greyed-out sidebar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
