Aman-Mittal opened a new pull request, #389: URL: https://github.com/apache/fineract-backoffice-ui/pull/389
Rolls up the open contributor PRs whose commits carry no GPG signature, cherry-picked onto current `main` and re-signed. Every commit keeps its original author — only the committer and signature are mine, so credit and the ASF paper trail are unaffected. Opened as a draft to get CI on the combined set. Unit tests are still running locally as I open this. ## Included | PR | Author | Commit | |---|---|---| | #332 | @YinkaMetrics | `test(interop): cover health check states` | | #333 | @YinkaMetrics | `refactor(organization): use formatArrayDate helper` | | #334 | @YinkaMetrics | `fix(charges): show load errors and retry` | | #345 | @Berserk-hub150 | `refactor(products): use formatArrayDate helper` | | #366 | @HurrairaBaloch | `fix(ux): replace native confirm on accounting, organization and working-capital deletes` | All five cherry-picked onto `main` without conflict. `lint`, `i18n:check` and `format:check` are clean on the combined branch. ## Excluded, and why Three unsigned PRs do not apply to current `main` and are not mechanical to fix. None of these are a judgement on the change itself — they need their authors, not me: - **#260** (@Guflly) — already on `main`. `messageFor` in `src/app/core/interceptors/error.interceptor.ts` now performs exactly this distinction via `isDomainRuleViolation`, matching on `validation.msg.domain.rule.violation` plus a populated `errors[]`. The PR and `main` arrived at the same logic independently. This should be closed as already fixed rather than merged, and #260 deserves a thank-you for getting there first. - **#331** (@Iyamokuma) — conflicts in `src/app/layout/header.component.ts` and `navigation-config.service.spec.ts`. Both areas moved on `main` since the PR was opened. Needs a rebase by the author. - **#335** (@YinkaMetrics) — conflicts in `products.routes.ts`. `main` has since added a `recurring-deposits/:accountId/transactions/create` route with its own guard, permission and title; this PR replaces that path with `:command`. How the guard and title carry over to the parameterised route is a design call, not a merge resolution. The remaining open PRs (#365, #325, #311, #312, #313, #316, #207) are all signed already — the `E` status when checking locally is just an unavailable public key, not a missing signature. ## Note on shape Five unrelated changes in one PR is not how these should normally land, and it makes a revert coarser than it ought to be. If you would rather, each commit here is standalone and cherry-picks cleanly on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
