rymghosn opened a new pull request, #6284:
URL: https://github.com/apache/fineract/pull/6284
Currently, when a client, loan, or savings account has one or more
maker-checker actions awaiting checker approval, there is no way to discover
this from the corresponding GET API response. A caller has to separately query
the checker inbox/pending-audit endpoints and correlate entries by entity,
which is easy to miss and leaves API consumers unaware that the record they
just fetched has a pending change awaiting approval.
This PR adds a pendingMakerCheckerApprovals field to the ClientData,
LoanAccountData, SavingsAccountData, and DepositAccountData (fixed/recurring
deposit) response objects. When a GET request for one of these entities is
served, the field is populated with any CommandSource entries still
AWAITING_APPROVAL for that entity (id, action name, entity name, permission
code, maker username, and submission date), or omitted (null) when there is
nothing pending.
Changes:
- New PendingMakerCheckerData DTO and
MakerCheckerReadService/MakerCheckerReadServiceImpl to look up pending
CommandSource rows by
loan/client/savings id.
- New CommandSourceRepository.findPendingBy{Loan,Client,Savings}Id queries
(join fetch c.maker to avoid N+1 lookups for the maker username).
- Wired into ClientReadPlatformServiceImpl#retrieveOne,
LoanReadPlatformServiceImpl#retrieveOne,
SavingsAccountReadPlatformServiceImpl#retrieveOne, and
DepositAccountReadPlatformServiceImpl#retrieveOne.
This is a read-only, additive change — it does not alter maker-checker
approval/permission logic itself, only exposes existing pending-approval
state that was previously only visible via the checker inbox.
PR:(https://issues.apache.org/jira/browse/FINERACT-2763)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
