Cocoa-Puffs commented on code in PR #6276: URL: https://github.com/apache/fineract/pull/6276#discussion_r3853257982
########## fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/messaging/event/workingcapitalloan/transaction/WorkingCapitalLoanChargeAdjustmentPostBusinessEvent.java: ########## @@ -0,0 +1,27 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.test.messaging.event.workingcapitalloan.transaction; + +public class WorkingCapitalLoanChargeAdjustmentPostBusinessEvent extends AbstractWorkingCapitalLoanTransactionEvent { Review Comment: We had a discussion with Oleksii about this. Since he also renamed this business event in his PR that Arnold mentioned I reverted the rename here to avoid potential conflicts. Peter created an e2e test for the renamed charge adjustment event on this PR as well and when I reverted the change he reworked the test to use the original name of the event. Should we drop this test from this PR entirely, since Oleksii's PR will cover this event with tests too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
