DeathGun44 commented on code in PR #6321: URL: https://github.com/apache/fineract/pull/6321#discussion_r3865560489
########## integration-tests/src/test/java/org/apache/fineract/integrationtests/ExternalIdSupportIntegrationTest.java: ########## Review Comment: looked into it, It did go through Feign, but the base class was throwing the response away: it kept only the id and rebuilt a PostLoansResponse by hand, with a second GET to fetch the external id back. POST /loans already returns all of it. It now returns the client's response directly. The loan() test asserts the external id right after applying and passes, so the extra GET was never needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
