jaredrainsha opened a new pull request, #462: URL: https://github.com/apache/fineract-backoffice-ui/pull/462
## What and why Replace the three remaining manual Fineract array-date conversions in the `products` feature with the existing `formatArrayDate` helper. This removes repeated 1-based month arithmetic while preserving the existing missing-date guards and ISO values expected by the date controls. This covers the remaining `products` portion of #257. The default value sites that intentionally use `toIsoDate(new Date())` are unchanged. Part of #257. ## Verification - `npm test -- --watch=false --progress=false` — 414/414 Karma tests passed - `npm run test:unit -- --watch=false --progress=false` — 164 files and 959/959 Vitest tests passed - `npm test -- --watch=false --include='src/app/features/products/fixed-deposits/fixed-deposit-form.component.spec.ts'` — 16/16 focused tests passed - `npm run test:unit -- --include='src/app/features/products/savings-account-transaction-form.component.test.ts' --watch=false` — 5/5 focused tests passed - `npm run lint` - `npm run format:check` - `npm run build` - `npm run check:icons` - `npm run i18n:check` - `./scripts/check-license.sh` - `git diff --check` No real Fineract backend was required because this is a behavior-preserving refactor covered by component/unit tests and the repository-wide build and static checks. ## Screenshots Not applicable; there is no UI or visible date change. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. (No new component or service code.) - [x] User-facing strings use translation keys. (No user-facing strings changed.) - [x] I added or updated tests appropriate to this change. (Existing component coverage plus both full unit suites verify behavior.) - [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. (No UI workflow changed.) - [x] Commits are signed — the commit was created with GitHub's verified signature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
