Aman-Mittal commented on code in PR #6340:
URL: https://github.com/apache/fineract/pull/6340#discussion_r3902707300
##########
.github/workflows/build-quality-checks.yml:
##########
@@ -300,3 +300,53 @@ jobs:
- name: Run Spotless
run: ./gradlew spotlessCheck
+
+ licenses:
+ if: github.event_name == 'pull_request'
+ runs-on: ubuntu-24.04
+ timeout-minutes: 45
+
+ env:
+ TZ: Asia/Kolkata
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+ BASE_SHA: ${{ github.event.pull_request.base.sha }}
+
+ steps:
+ # This job diffs the PR head against its target branch, so it needs
Review Comment:
This is because Fineract already has some compile-only dependencies with
Category X licenses that are not bundled with the Fineract release artifacts.
Since these dependencies are intentionally present only at
compile/development time, we don't want the CI check to flag them on every PR.
The check is therefore focused on newly introduced or upgraded dependencies,
where a license change would actually require review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
