Eyad-Sharkawy commented on code in PR #6365:
URL: https://github.com/apache/fineract/pull/6365#discussion_r3915404890
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityDataTableChecksData.java:
##########
@@ -20,23 +20,24 @@
import java.io.Serializable;
import org.apache.fineract.infrastructure.core.data.EnumOptionData;
+import org.apache.fineract.infrastructure.core.data.StringEnumOptionData;
/**
* Immutable data object for role data.
*/
public class EntityDataTableChecksData implements Serializable {
private final long id;
- private final String entity;
+ private final StringEnumOptionData entity;
Review Comment:
Thanks for the review and recommendation, @adamsaghy! I have updated the PR
to keep entity as a String for backward compatibility and introduced entityData
as StringEnumOptionData. The commit has been amended and force-pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
