vaishaldsouza opened a new pull request, #478:
URL: https://github.com/apache/fineract-backoffice-ui/pull/478
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Commits must be signed to merge — see CONTRIBUTING.md#commit-signing if
you haven't set this up. -->
## What and why
Regenerates the OpenAPI TypeScript Angular client from Fineract's updated
Swagger spec, and fixes a Windows bug in the spec preprocessor that caused
`preprocess-spec.mjs` to be skipped on direct invocation (path backslashes
broke the `import.meta.url` main-module check). The preprocessor's existing
deterministic `(method, path)` operationId logic keeps generated method
names
stable across spec updates instead of shifting with document order, so once
it actually runs (now fixed cross-platform), all call sites - including
`floating-rate-form.component.ts` - compile cleanly with no changes needed.
Closes #448
## Verification
- `npm run generate-api` — clean generation
- `npm run verify-api-client` — clean diff, exit code 0
- `npm run build` — 0 errors
- `npm run lint` — 0 ESLint errors
- `npm run format:check` — passed
- `npm run test:unit` — 1336 Vitest tests passed
- `npm test -- --watch=false` — 40 Karma/Jasmine specs passed
- `npm run check:icons` — 115 icons registered
- `npm run i18n:check` — 1607 keys verified
- `./scripts/check-license.sh` — passed
- `npx playwright test --project=mocked` — 336/340 passed; the 4 failures
(`accessibility.spec.ts`, `loan-product-down-payment.spec.ts`) are
pre-existing parallel-execution flakiness, confirmed unrelated to this
change by rerunning in isolation with `--workers=1` (16/16 passed)
- Real-backend/loan e2e specs (`loan-*.spec.ts`, `full-demo.spec.ts`) were
**not** run against a live Fineract instance - this change touches only
the generated client and preprocessor script, not runtime request/response
handling, so backend-dependent e2e coverage wasn't exercised
## Screenshots
<!-- Add screenshots or a short recording for UI changes. Write "Not
applicable" for non-UI changes. -->
## Checklist
<!-- Check each item, or explain why it does not apply. -->
- [ ] I did not hand-edit generated files under `src/app/api/`.
- [ ] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [ ] User-facing strings use translation keys.
- [ ] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [ ] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [ ] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
