zhangxinyao88 commented on code in PR #476:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/476#discussion_r3924413574
##########
.github/workflows/ci.yml:
##########
@@ -231,17 +231,19 @@ jobs:
restore-keys: |
${{ runner.os }}-angular-test-
- name: Run Tests with Coverage
+ # The legacy runner has no work once the Karma baseline reaches zero.
Its complete
+ # removal, including its configuration and dependencies, follows in a
separate change.
+ if: ${{ hashFiles('src/**/*.spec.ts', 'projects/**/*.spec.ts') != '' }}
Review Comment:
This is the final Karma batch, so without the guard the existing Karma step
has no matching specs and CI fails. I kept the minimal guard here to make the
final migration mergeable; I’ll move the broader removal of Karma
configuration, dependencies, and migration-only code into the follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
