adamsaghy commented on PR #6188: URL: https://github.com/apache/fineract/pull/6188#issuecomment-5526673324
> <img alt="Screenshot 2026-08-04 141147" width="907" height="430" src="https://private-user-images.githubusercontent.com/188246568/631138130-8aebb835-0e8e-44e7-88df-a218837f5755.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODg0MzYzODcsIm5iZiI6MTc4ODQzNjA4NywicGF0aCI6Ii8xODgyNDY1NjgvNjMxMTM4MTMwLThhZWJiODM1LTBlOGUtNDRlNy04OGRmLWEyMTg4MzdmNTc1NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDkwM1QxMTQ4MDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MmJiMDcwZDU1MDZjMTIyNWYzNDJlNjJjMDVjY2MwYTM1ZjQzYWYxOTA1NDllNGE3NGZiOGFiNDMyYmQ2YjY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.vuycESBnbYSiBjh_fNVy84gXbyTxlXkeOKMauXYXZfk";> > Looking at the screenshot of the current UI (toggle off, "Show Closed Accounts"), all clients — including closed ones — are already returned by default. That doesn't quite line up with the generic status-filtering solution being proposed in this PR. > > What we'd suggest instead: keep the generic status filtering, but flip the UI semantics — rename the toggle label from "Show Closed Accounts" to "Hide Closed Accounts". In its default (off) state, all clients continue to be returned as today, including closed ones. When toggled on, we hide closed accounts by adjusting the status filter param accordingly. > > This keeps default behavior unchanged, gives users an explicit way to exclude closed accounts, and removes the mismatch between the switch's current label/intent and the filtering approach proposed here. > > Posting this as pending your feedback — want to align on this before we land on a fully working solution. > > @adamsaghy @IOhacker To be honest, I would not change UI to fetch closed clients by default. Lets have it as an extra step. From backend point of view, filtering by status is the better thing and no filtering means return all entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/188246568/631138130-8aebb835-0e8e-44e7-88df-a218837f5755.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODg0MzYzODcsIm5iZiI6MTc4ODQzNjA4NywicGF0aCI6Ii8xODgyNDY1NjgvNjMxMTM4MTMwLThhZWJiODM1LTBlOGUtNDRlNy04OGRmLWEyMTg4MzdmNTc1NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDkwM1QxMTQ4MDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MmJiMDcwZDU1MDZjMTIyNWYzNDJlNjJjMDVjY2MwYTM1ZjQzYWYxOTA1NDllNGE3NGZiOGFiNDMyYmQ2YjY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.vuycESBnbYSiBjh_fNVy84gXbyTxlXkeOKMauXYXZfk"](https://private-user-images.githubusercontent.com/188246568/631138130-8aebb835-0e8e-44e7-88df-a218837f5755.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODg0MzYzODcsIm5iZiI6MTc4ODQzNjA4NywicGF0aCI6Ii8xODgyNDY1NjgvNjMxMTM4MTMwLThhZWJiODM1LTBlOGUtNDRlNy04OGRmLWEyMTg4MzdmNTc1NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDkwM1QxMTQ4MDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MmJiMDcwZDU1MDZjMTIyNWYzNDJlNjJjMDVjY2MwYTM1ZjQzYWYxOTA1NDllNGE3NGZiOGFiNDMyYmQ2YjY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.vuycESBnbYSiBjh_fNVy84gXbyTxlXkeOKMauXYXZfk"){kind=link}