adamsaghy commented on code in PR #6209:
URL: https://github.com/apache/fineract/pull/6209#discussion_r3925309472


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadServiceImpl.java:
##########
@@ -204,6 +204,19 @@ public FineractEntityRelationData mapRow(final ResultSet 
rs, @SuppressWarnings("
     @Override
     public Collection<FineractEntityToEntityMappingData> 
retrieveEntityToEntityMappings(Long mapId, Long fromId, Long toId) {
 
+        if (fromId == 0) {

Review Comment:
   Can we rewrite this to use JPQL and Repository instead? I am not a big fan 
of "native queries" and manual mapping.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to