adamsaghy commented on code in PR #6226:
URL: https://github.com/apache/fineract/pull/6226#discussion_r3925386024
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanCollateralManagementData.java:
##########
@@ -35,4 +33,22 @@ public class LoanCollateralManagementData {
private BigDecimal totalCollateral;
private Long id;
+
+ private String name;
+
+ private BigDecimal unitPrice;
+
+ private BigDecimal pctToBase;
+
+ public LoanCollateralManagementData(Long clientCollateralId, BigDecimal
quantity, BigDecimal total, BigDecimal totalCollateral, Long id,
Review Comment:
We prefer @AllArgsConstructor over manual constructor. Please undo this
change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
