Eyad-Sharkawy opened a new pull request, #6405:
URL: https://github.com/apache/fineract/pull/6405

   ## Description
   Resolves [FINERACT-848](https://issues.apache.org/jira/browse/FINERACT-848).
   
   Adds the ability to override product-level interest rate charts with a 
custom nominal annual interest rate for Fixed Deposit (FD) and Recurring 
Deposit (RD) accounts:
   - Added `isRateChartOverridden` boolean flag to deposit account terms and 
data models.
   - Updated domain interest calculation and validation in 
`FixedDepositAccount` and `RecurringDepositAccount` so that when 
`isRateChartOverridden` is enabled, custom nominal annual interest rate takes 
precedence and bypasses product chart slab lookups.
   - Added API request/response parameters, Swagger documentation annotations, 
and Liquibase database migration.
   - Added comprehensive unit tests in `DepositAccountRateChartOverriddenTest`.
   
   ## Checklist
   - [x] Write the commit message as per our guidelines
   - [x] Acknowledge that we will not review PRs that are not passing the build 
("green")
   - [x] Create/update unit or integration tests for verifying the changes made
   - [x] Follow our coding conventions
   - [x] Add required Swagger annotation and update API documentation
   - [x] This PR must not be a "code dump"
   - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to