Aman-Mittal opened a new issue, #510:
URL: https://github.com/apache/fineract-backoffice-ui/issues/510

   Both files tell the reader to run the unit suite as:
   
   ```bash
   npm run test -- --watch=false --browsers=ChromeHeadless
   ```
   
   - `RELEASING.md:111`, inside the release checklist
   - `DOCS/RBAC.md:192`, under "Running the tests"
   
   That command was correct under Karma. Since the Vitest migration (ADR 0004, 
PR #476) it fails before running anything:
   
   ```
   $ npm run test -- --watch=false --browsers=ChromeHeadless
   
   An exception occurred during test execution:
   Error: The "browsers" option requires either "playwright" or "webdriverio" 
to be
   installed within the project. Please install one of these packages and rerun 
the
   test command.
       at VitestExecutor.initializeVitest 
(@angular/build/.../vitest/executor.js:250:19)
   ```
   
   The builder's provider check looks for the bare `playwright` or 
`webdriverio` package. This project depends on `@playwright/test` for the e2e 
suite, which does not satisfy it, so `--browsers` cannot work here without 
adding a dependency the unit suite has no other use for. Vitest already runs 
the suite in jsdom, which is the point of the migration.
   
   `--watch=false` is not broken — the builder still accepts a `watch` option — 
but it is redundant outside a TTY, where watch mode is off by default.
   
   RELEASING.md is the worse of the two: a release manager working down that 
checklist hits a hard failure at the test step and has no signal about whether 
it is their environment or the code.
   
   ### What it should say
   
   `npm run test:unit`, which is what `ci.yml` runs.
   
   ### How to check it
   
   ```bash
   npm ci
   npm run test -- --watch=false --browsers=ChromeHeadless   # fails as above
   npm run test:unit                                         # 236 files, 1415 
tests, exit 0
   ```
   
   Same root cause as the `dev-release.yml` breakage fixed on that branch — the 
flag pair outlived the runner in more than one place.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to