Aman-Mittal commented on issue #485: URL: https://github.com/apache/fineract-backoffice-ui/issues/485#issuecomment-5558639847
Correcting the report now that this is closed, so it does not mislead anyone who finds it later. The line "`addIcons` appears **nowhere** in `src/app`" is wrong. It is in `src/bootstrap.ts`, outside the path I grepped, and the app has an explicit icon registry — it does not rely on name-based lazy loading as I claimed. @ryux1 had it right in the comment above. The symptom was real and the fix was the right one: `flash-outline` and `checkmark-done-outline` were simply missing from that registry, and `check-icons` only scanned `<ion-icon>` bindings, so a name set in `navigation-config.service.ts` was invisible to it. The "Suggested fix" section describing the whole approach as missing should be read as describing two absent entries, not an absent mechanism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
