ryux1 commented on code in PR #532:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/532#discussion_r3954528876
##########
src/app/shared/components/stepper/stepper.component.ts:
##########
@@ -38,6 +38,8 @@ import { TranslatePipe } from '../../../core/adapters';
class="step"
[class.step-done]="i < currentIndex()"
[class.step-active]="i === currentIndex()"
+ [attr.aria-label]="label | appTranslate"
Review Comment:
The label is already passed through `appTranslate` for both the visible step
text and the `aria-label`.
I also recorded the focused Playwright test on the Pixel 7 viewport. It
passes and shows all three markers inside the viewport with only the active
translated label visible:
[Video recording
(WebM)](https://raw.githubusercontent.com/ryux1/fineract-backoffice-ui/evidence/pr-532-mobile-stepper/.pr-evidence/532/mobile-stepper.webm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
