DeathGun44 commented on PR #6419:
URL: https://github.com/apache/fineract/pull/6419#issuecomment-5585277456
API backward-compatibility check: 16 expected violations, all from one
schema correction verify-api-backward-compatibility fails on this PR.
Measured locally with swagger-brake on a sliced spec, plus an identical-spec
control run that reported no violations.
All 16 are on GET /v1/savingsaccounts/{accountId} and all stem from a single
one-line fix in SavingsAccountChargeData. The field is a java.time.MonthDay.
Jackson serialises it as the ISO-8601 string --01-15, but the schema generator
introspected the type as a bean and published an object with
dayOfMonth/month/monthValue.
The old schema described a shape the server has never sent, so no client
could have been relying on it - any client that tried failed exactly as ours
did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
