subhranshudash13-dotcom opened a new pull request, #537:
URL: https://github.com/apache/fineract-backoffice-ui/pull/537
## What and why :
The main Clients list was passing a hardcoded `legalForm` value of `1`,
which restricted the results to Person clients and excluded Entity clients.
This change removes the hardcoded value so the main client list is no longer
restricted to a specific legal form and can return both Person and Entity
clients.
Closes #534
Unblocks #377
## Verification :
- Added `src/app/features/clients/clients-list.component.test.ts` to cover
the `getClients()` call without a hardcoded `legalForm`.
- Added `seedEntityClient` in `e2e/utils/seed-api.ts` and an E2E regression
test in `e2e/client.spec.ts` covering Entity client visibility in the main
`/clients` list.
- Ran the repository validation checks successfully:
- `node scripts/check-icons.mjs`
- `node scripts/check-translations.mjs`
- `node scripts/check-a11y-names.mjs`
- `node scripts/check-route-permissions.mjs`
- `node scripts/check-nav-ids.mjs`
- `node scripts/check-api-surface.mjs`
- `npx prettier --check` on touched files
- `node --test "scripts/*.test.mjs"`
- `node --test "eslint-rules/*.test.js"`
- The E2E regression test has been added but has not yet been run locally
against the Docker/Fineract backend.
## Screenshots :
Not applicable — this is a non-visual fix to the client list query.
## Checklist :
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [x] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
