alberto-art3ch opened a new pull request, #6425: URL: https://github.com/apache/fineract/pull/6425
## Description Adds the optional `charges` parameter to the Working Capital loan product, mirroring how a term loan product declares the charges it offers: new `m_wc_loan_product_charge` join table, `charges` on POST/PUT, and the resulting list exposed on the product GET and on the account template (`loanData.product.charges`). Unlike term loans, only charges defined with `chargeAppliesTo = WORKING_CAPITAL_LOAN` and matching the product currency can be attached, and a charge offered by a WC product can no longer be deleted or deactivated. The association is a catalogue and does not constrain what may later be applied to an account; the product template now returns real `chargeOptions` / `penaltyOptions` instead of the previous empty placeholders. [FINERACT-2455](https://issues.apache.org/jira/browse/FINERACT-2455) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
