Aman-Mittal commented on PR #6420:
URL: https://github.com/apache/fineract/pull/6420#issuecomment-5617595992
@elnafateh
Hi Reviewed this with the help of Copilot
While with prompt "Help me review this pull request" recommends for merge
but i dig a little deeper, As i am not familier with office hierarchy
So it is like this from what i find
Office Hierarchy is a string-based path representation of an organization's
office structure in Fineract. It's used to enforce authorization constraints -
ensuring users can only access resources belonging to their office or
subordinate offices.
something like
Hierarchy String Format: ".parentOfficeId.childOfficeId."
Example:
- Root office (Head Office): "."
- Branch A (child of root): ".1."
- Sub-branch A1 (child of A): ".1.2."
- Sub-branch A2 (child of A): ".1.3."
Code wise there is no red flags but there are some coverage it needs to
expand on
- Parent office can access child office resources (hierarchy prefix
working correctly)
- Child office cannot access parent office resources (negative case)
- Same office transfer (positive case)
- Multi-level hierarchies (.1.2.3. scenarios)
Also i think we can also add documentation.
If that can get covered then i can review more.
@adamsaghy @IOhacker fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
