shubhamchaudhary29 opened a new pull request, #6427: URL: https://github.com/apache/fineract/pull/6427
## Description Jira: https://issues.apache.org/jira/browse/FINERACT-2767 ### Problem Previously, `PUT /v1/taxes/component/{id}` allowed updating any field of a Tax Component, including its percentage, debit/credit GL account mappings, and start date. If a tax component was already linked to active transactions (via a Tax Group referenced by one or more Charges), modifying its percentage or GL accounts would compromise historical audit trails and cause accounting inconsistencies. ### Solution This PR implements field locking on `TaxComponent` based on usage status: 1. **Usage Check**: A tax component is considered in use if it belongs to a `TaxGroup` that is referenced by at least one `Charge` (via `ChargeRepository.existsByTaxGroupContainingTaxComponent(taxComponentId)`). 2. **Field Locking When In Use**: - `percentage`, `debitAccountType`, `debitAccountId`, `creditAccountType`, and `creditAccountId` are locked and cannot be modified. - `name` remains editable. - **Two-tier `startDate` rule**: - If `startDate` is today or in the past (already active), it cannot be modified (`validation.msg.tax.component.start.date.cannot.be.modified.after.activation`). - If `startDate` is in the future, it can be updated to another future date (> today), even if the component is in use. 3. **Field Updates When Not In Use**: - All fields are editable, including updating GL accounts (`debitAccountType`, `debitAccountId`, `creditAccountType`, `creditAccountId`) or percentage. 4. **API and Swagger Documentation**: - Added `accountsEditable` boolean property to `TaxComponentData` and OpenAPI annotations. - Updated GET `/v1/taxes/component/{id}` template behavior so that GL account dropdown options are omitted when accounts are locked. 5. **Testing**: - Comprehensive unit tests added in `fineract-tax` and `fineract-provider` testing validation rules, domain state updates, service layer permissions, and response payloads. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
