[
https://issues.apache.org/jira/browse/FINERACT-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Saghy resolved FINERACT-2746.
----------------------------------
Resolution: Fixed
> Migrate the organisation reference data integration tests to the Feign client
> -----------------------------------------------------------------------------
>
> Key: FINERACT-2746
> URL: https://issues.apache.org/jira/browse/FINERACT-2746
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Affects Versions: 1.15.0
> Reporter: Krishna Mewara
> Assignee: Krishna Mewara
> Priority: Trivial
> Labels: beginner-friendly, feign-migration, swagger
> Fix For: 1.16.0
>
>
> Description
>
> Part of FINERACT-2609. Migrates six organisation/reference-data integration
> test classes (10 tests) from REST-assured and the legacy Retrofit client to
> the generated Feign client.
>
> Scope:
> - OfficeIntegrationTest
> - RatesTest
> - ProductMixIntegrationTest
> - HookIntegrationTest
> - CashierSummaryAndTransactionsTest
> - ExternalEventConfigurationIntegrationTest
>
> Four superseded helpers are removed (RatesHelper, ProductMixHelper,
> HookHelper, CashierTransactionsHelper); each has no caller other than its own
> test. OfficeHelper is left in place, as 18 other tests still use it.
>
> No production code is changed, and no file touched here is shared with any
> other in-flight migration, so this can be reviewed and merged independently.
>
> Also fixes CashierSummaryAndTransactionsTest, which creates a staff member,
> teller and cashier and then discards all three IDs, asserting against a
> hardcoded teller/cashier id of 1. It passes only on a pristine database.
>
> Out of scope, each needing its own ticket: the external services
> configuration, templates, global configuration, scheduler jobs, SMS campaign
> and batch tests, plus the SQL-injection suite in client/OfficeTest. These are
> blocked by SDK or swagger defects rather than by effort.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
