[
https://issues.apache.org/jira/browse/FINERACT-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18115672#comment-18115672
]
MARAM SAI SWARAN commented on FINERACT-2833:
--------------------------------------------
Hi, I would like to contribute to FINERACT-2833. I checked current develop and
found that the ticket spans Client, Savings, Share, and
Accounting endpoints, while a few listed Client fields are already
documented—for example, staffId on GET /clients/\{id} and submittedOnDate on
POST /clients.
To keep the work reviewable, may I take one small first slice: document
genderOptions, clientTypeOptions, and clientClassificationOptions in the GET
/clients/template OpenAPI response? The runtime template already returns these
collections. I would add focused OpenAPI/generated-client validation and leave
the other endpoint groups for separate follow-up work.
> OpenAPI gaps: Institution Clients
> ---------------------------------
>
> Key: FINERACT-2833
> URL: https://issues.apache.org/jira/browse/FINERACT-2833
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Aleksandar Vidakovic
> Priority: Major
> Labels: beginner-friendly
>
> h4. /clients/{id}/charges/{chargeId}
> GetClientsChargesPageItems missing clientTransactionDatas
> h4. /clients/template
> GetClientsTemplateResponse missing genderOptions, clientTypeOptions,
> clientClassificationOptions
> h4. /clients
> PostClientsRequest missing staffId, isStaff, submittedOnDate
> h4. /clients/{id} (GET)
> GetClientsClientIdResponse missing legalFormId, middlename, dateOfBirth,
> genderId, staffId, mobileNo, clientTypeId, clientClassificationId,
> submittedOnDate
> h4. /clients/{id} (PUT)
> PutClientsClientIdRequest only has externalId, resourceExternalId
> h4. /savingsaccounts/template
> GetSavingsAccountsTemplateResponse missing fieldOfficerOptions,
> interestCompoundingPeriodTypeOptions, interestPostingPeriodTypeOptions,
> interestCalculationTypeOptions, interestCalculationDaysInYearTypeOptions,
> lockinPeriodFrequencyTypeOptions, savingsAmountOnClosureTypeOptions,
> withdrawalFeeTypeOptions, chargeOptions, currencyOptions
> h4. /savingsaccounts
> PostSavingsAccountsRequest missing fieldOfficerId, nominalAnnualInterestRate,
> interestCompoundingPeriodType, interestPostingPeriodType,
> interestCalculationType, interestCalculationDaysInYearType,
> minRequiredOpeningBalance, lockinPeriodFrequency,
> h4. /accounts/share/template
> GetAccountsTypeTemplateResponse missing chargeOptions,
> minimumActivePeriodFrequencyTypeOptions``lockinPeriodFrequencyTypeOptions,
> currencyOptions
> h4. /accountingrules (POST) / /accountingrules/{id} (PUT)
> AccountRuleRequest missing debitTags, creditTags, allowMultipleDebitEntries,
> allowMultipleCreditEntries
> h4. /accountingrules/{id} (GET)
> AccountingRuleData missing accountToDebit,accountToCredit
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
