clayburn opened a new pull request, #6461: URL: https://github.com/apache/fineract/pull/6461
## Description Resolves [FINERACT-2840](https://issues.apache.org/jira/browse/FINERACT-2840). `settings.gradle` derived `isCI` from the `JENKINS_URL` environment variable. Fineract's CI runs entirely on GitHub Actions, which never sets `JENKINS_URL`, and there is no Jenkins configuration anywhere in the repository — so `isCI` was always `false`. Its only consumer is `buildScan.uploadInBackground = !isCI`, which meant background upload stayed enabled on CI. On an ephemeral GitHub Actions runner the job can terminate before a backgrounded Build Scan upload completes, losing the scan. This keys the check to `GITHUB_ACTIONS`, which GitHub Actions always sets. Build Scan uploads are now synchronous on CI, and remain backgrounded for local developer builds where the added latency would be noticeable. Also updates the Develocity Gradle plugin from 4.5.0 to 4.5.1. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. <!-- Build configuration change; exercised by every CI workflow run on this PR. --> - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes <!-- No API changes. --> - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
