adamsaghy commented on code in PR #6472:
URL: https://github.com/apache/fineract/pull/6472#discussion_r4040096683


##########
build.gradle:
##########
@@ -62,29 +62,7 @@ buildscript {
             [
                 'fineract-avro-schemas',
                 'fineract-client',
-                'fineract-client-feign',

Review Comment:
   @IOhacker I am not sure i follow you on this one.
   
   The built fineract-client / fineract-client-feign / fineract-avro-schemas 
are not depending on anything but its own files. 
   
   I see no reason to publish all fineract modules since it is not designed to 
be used as dependencies in any project, but their sole purpose to be 
modularized internally.
   
   Any project who is intended to communicate with Fineract via 
fineract-client-feign, just add it as a jar dependency and use it. They dont 
need any of the other modules or anything further.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to