Cocoa-Puffs opened a new pull request, #6479: URL: https://github.com/apache/fineract/pull/6479
## Description CobPartitioningTest.testLoanCOBPartitioningQuery() frequently fails in Github Actions runs with: Exception Description: Syntax error parsing [SELECT lt.typeOf AS transactionType, ... ]. The select item is missing from the result variable declaration. SELECT lt.typeOf [ AS transactionType ] ... The SELECT clause has 'lt.typeOf' and 'AS transactionType' that are not separated by a comma. The culprit is the query: findTransactionDataForForeclosureIncome() in LoanTransactionRepository. It uses "AS <alias>" in the select clause which are in practice JPQL result-variables. The parse error is EclipseLink's Hermes parser reporting that the grammar singleton it consulted has no result-variable rule registered, likely because another thread is still initializing it. My proposed fix is to bypass result-variables by using a constructor expression, that every other query uses too. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
