Samer-Melhem-FOO commented on PR #6136: URL: https://github.com/apache/fineract/pull/6136#issuecomment-5771698212
@adamsaghy Rebased onto the latest `develop` and force-pushed. The rebase was conflict-free this time, and `0254_add_undo_accounttransfer_permission.xml` is still free upstream, so no renumbering was needed. I also pushed a second commit that was missing: `AccountTransferOverdraftTest.preserveTransferLinkWhenBackdatedDepositRecalculatesOverdraft()` was still calling `undo` with the create-command's `resourceId` (an `m_account_transfer_details.id`) instead of the transfer-transaction id this PR's fix requires. It now passes `withdrawal.getTransfer().getId()`, which the savings transactions mapper populates from `m_account_transfer_transaction.id` — the same key space `AccountTransfersReadPlatformServiceImpl.retrieveOne` looks up (`where att.id = ?`). It passed before only because both id sequences coincide in a fresh test database. On the two failing checks in the previous run: both looked like CI infrastructure rather than this PR. - `E2E Tests (Shard 9 of 20)` — the `fineract` container never became healthy (`curl … localhost:8443` returned `SSL_ERROR_SYSCALL` through all 30 retries), and the gradle invocation also hit `Failed to load eclipse groovy formatter: java.lang.IllegalArgumentException: 502 at https://download.eclipse.org/eclipse/updates/4.29/…/com.sun.jna_5.13.0.jar`. - `regression-safety` — ended with `The runner has received a shutdown signal … The operation was canceled.` before it got to the changelog checks. All 85 other checks were green, including every MariaDB integration shard. Locally on the rebased branch, `:fineract-provider:compileJava` and `:integration-tests:compileTestJava` both build clean and `spotlessJavaCheck` reports no violations in the touched files. Hopefully this run comes back green — happy to dig in if anything real shows up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
