alberto-art3ch opened a new pull request, #6493:
URL: https://github.com/apache/fineract/pull/6493
## Description
Global configuration lookups (`c_configuration` by name) run on almost every
request: ~17 single-row queries per
write request under load, the most executed statement of the platform. The
`@Cacheable("configByName")` never
hits because the default `TransactionBoundCacheManager` clears a shared
Ehcache instance on every transaction of
every thread, and it keeps doing so even after switching to SINGLE_NODE via
`PUT /caches`.
Changes, keeping the guarantee that every transaction starts from the
database:
- Transaction-bound cache entries are now stored per thread
(`ThreadLocalCacheStore`) and cleared only by that
thread's transaction boundaries and at request start; no cross-thread
clearing or locking.
- `RuntimeDelegatingCacheManager` forwards transaction hooks only to the
active manager, so SINGLE_NODE is no
longer wiped by the transaction-bound one.
- `GlobalConfigurationRepositoryWrapper` loads the whole table (76 rows)
once per transaction with a read-only
query and evicts it on writes; the single mutating caller uses a dedicated
for-update lookup.
Measured (k6, PostgreSQL 18, 36k loans): configuration statements per write
request 16.7 -> 5.8 (one 76-row round
trip per transaction instead of one per property), write p95 27 -> 28 ms,
read mix p95 86-105 -> 90 ms. No
client-visible behaviour change. New unit tests cover hook forwarding and
once-per-transaction loading.
[FINERACT-2684](https://issues.apache.org/jira/browse/FINERACT-2684)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [ ] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
