oleksii-novikov-onix commented on PR #6480:
URL: https://github.com/apache/fineract/pull/6480#issuecomment-5811756829

   > @oleksii-novikov-onix To cover all possibilities:
   > 
   > * Let's add a new field `relatedExternalResourceId` which accepts the 
`external id` of the target loan transaction
   >   
   >   * Similar behaviour like `relatedResourceId` but for external id
   
   Done.
   
   1. relatedExternalResourceId added to the body of discount fee and discount 
fee adjustment (both loan id and loan external id endpoints).
   2. Same behaviour as relatedResourceId - same checks, same order, same error 
codes, same response.
   3. Sending both fields at once is rejected with 400.
   4. Covered by e2e, including Batch API; docs updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to