Aman-Mittal opened a new issue, #627:
URL: https://github.com/apache/fineract-backoffice-ui/issues/627
## Summary
Split out of #624 rather than folded into its PR, because this is a
different defect with a different fix.
`ColumnDef.label` is rendered as `col.label | translate` by
`data-table.component.ts`, so a phrase there produces a visible raw key and
#624 now catches it statically. Three other screens hold `label` in a plain
object and render it **without a pipe at all**:
| File | Line | Renders as | Values |
| ---- | ---- | ---------- | ------ |
| `src/app/features/settings/working-days.component.ts` | 157–163 | `{{
day.label }}` (line 74) | `'Monday'` … `'Sunday'` |
|
`src/app/features/loans/loan-schedule-modify/loan-schedule-modify.component.ts`
| 178–179 | `{{ cmd.label }}` (line 90) | `'Calculate Repayment Schedule'`,
`'Force Recalculate Repayment Schedule'` |
| `src/app/features/dashboard/system-status.component.ts` | — | — | one
literal `label:` |
Because nothing translates them, they never miss and never render a raw key.
They simply stay English in Hindi and Korean, with no signal anywhere:
- `i18n:check` does not see them — there is no key and no pipe to check.
- The runtime handler does not see them — `translate()` is never called.
- The new `PHRASES` check does not see them — those files do not import
`ColumnDef`.
So this is the one remaining shape of the problem that has no guard at all.
## Fix
For each: add keys to `en.json`, replace the literals, and add `|
appTranslate` at the render site. The weekday labels are generic enough for
`COMMON.MONDAY` … `COMMON.SUNDAY`; the loan-schedule commands belong under
`LOAN_SCHEDULE_MODIFY`.
Worth considering alongside it: once these three are keys, a check could
require that a `label:` literal anywhere in feature code is key-shaped, not
just in `ColumnDef` files. 330 of 376 such literals already are. That would
make the guard total rather than contract-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
