[
https://issues.apache.org/jira/browse/FINERACT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna Mewara updated FINERACT-2859:
-------------------------------------
Description:
h2. What this is
Row 12 of the FINERACT-2609 roadmap. It moves the client, charges and
accounting integration tests off REST Assured and onto the generated Feign
client.
This is done in one PR, with separate commits for each area. The PR description
covers the details and how it was verified.
h2. Scope
||Area||Test classes||Tests||
|Client|ClientTest, ClientExternalIdTest,
ClientUndoRejectAndWithdrawalIntegrationTest, ClientAuditingIntegrationTest,
ClientCollateralIntegrationTest, ClientSearchTest, NotesTest,
ClientIdentifierTest, ClientTransactionTest, ClientChargesTest|74|
|Charges|ChargesTest, CollateralProductIntegrationTest|6|
|Accounting|AccountingScenarioIntegrationTest, AccountingRuleIntegrationTest,
FinancialActivityAccountsTest, ProvisioningIntegrationTest,
ProvisioningCategoryDeleteIntegrationTest|16|
That is 17 classes and 96 tests, counted on develop on 2026-09-26.
h2. Done when
The PR is merged, and none of the 17 classes uses REST Assured any more.
was:
Row 12 of the FINERACT-2609 roadmap. It moves the client, charges and
accounting integration tests off REST Assured and onto the generated Feign
client.
The work is split into three PRs, one per area, so each one stays reviewable.
All three use this ticket's ID. Each PR description covers what changed in that
area and how it was verified.
h2. Scope
||PR||Area||Test classes||Tests||
|1|Client|ClientTest, ClientExternalIdTest,
ClientUndoRejectAndWithdrawalIntegrationTest, ClientAuditingIntegrationTest,
ClientCollateralIntegrationTest, ClientSearchTest, NotesTest,
ClientIdentifierTest, ClientTransactionTest, ClientChargesTest|74|
|2|Charges|ChargesTest, CollateralProductIntegrationTest|6|
|3|Accounting|AccountingScenarioIntegrationTest, AccountingRuleIntegrationTest,
FinancialActivityAccountsTest, ProvisioningIntegrationTest,
ProvisioningCategoryDeleteIntegrationTest|16|
That is 17 classes and 96 tests, counted on develop on 2026-09-26.
h2. Done when
All three PRs are merged, and none of the 17 classes uses REST Assured any more.
> Migrate the client, charges and accounting integration tests to the Feign
> client
> --------------------------------------------------------------------------------
>
> Key: FINERACT-2859
> URL: https://issues.apache.org/jira/browse/FINERACT-2859
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Affects Versions: 1.15.0
> Reporter: Krishna Mewara
> Assignee: Krishna Mewara
> Priority: Trivial
> Labels: beginner-friendly, client, feign-migration, migration
> Fix For: 1.16.0
>
>
> h2. What this is
> Row 12 of the FINERACT-2609 roadmap. It moves the client, charges and
> accounting integration tests off REST Assured and onto the generated Feign
> client.
> This is done in one PR, with separate commits for each area. The PR
> description covers the details and how it was verified.
> h2. Scope
> ||Area||Test classes||Tests||
> |Client|ClientTest, ClientExternalIdTest,
> ClientUndoRejectAndWithdrawalIntegrationTest, ClientAuditingIntegrationTest,
> ClientCollateralIntegrationTest, ClientSearchTest, NotesTest,
> ClientIdentifierTest, ClientTransactionTest, ClientChargesTest|74|
> |Charges|ChargesTest, CollateralProductIntegrationTest|6|
> |Accounting|AccountingScenarioIntegrationTest, AccountingRuleIntegrationTest,
> FinancialActivityAccountsTest, ProvisioningIntegrationTest,
> ProvisioningCategoryDeleteIntegrationTest|16|
> That is 17 classes and 96 tests, counted on develop on 2026-09-26.
> h2. Done when
> The PR is merged, and none of the 17 classes uses REST Assured any more.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)