shivaansh0610-LUFFY opened a new pull request, #641:
URL: https://github.com/apache/fineract-backoffice-ui/pull/641
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Commits must be signed to merge — see CONTRIBUTING.md#commit-signing if
you haven't set this up. -->
## What and why
<!-- One or two sentences explaining what changed and why. -->
The Audit Logs screen showed two permanently blank columns when
maker-checker is off, had no free-text search unlike the other list screens,
and had a few visual inconsistencies. This hides the empty Checker / Checked
Date columns, adds the standard search box, aligns the Filters bar with the
card, and renders Result as a status pill.
- **Checker / Checked Date:** hidden unless at least one loaded row has a
checker or a checked date. They reappear as soon as a row has one.
- **Search:** the table now uses the shared "Type to search…" box. The
audits endpoint has no free-text parameter, so it filters the rows already
loaded on the current page rather than querying the server.
- **Filters bar:** margin fixed so it lines up with the card and the table
beneath it, with a gap below it.
- **Result:** shown with `app-status-badge`. The badge now treats
`processed` / `success` as green and `failure` / `failed` / `error` as red;
anything else (including `unprocessed`) stays neutral.
- **Not changed:** the Export CSV button style, which is a design decision
rather than a bug.
Closes #582
## Verification
<!-- List what you ran and what you checked. Note whether the UI was
exercised with mocks, a real Fineract backend, or both. -->
- Unit tests for the audit logs component and the status badge pass,
including new cases for the hidden and shown checker columns, the search and
the badge colours.
- `eslint`, `prettier --check`, `tsc --noEmit -p tsconfig.app.json` and `npm
run i18n:check` are clean.
- UI exercised in Chrome at 1440x900, dark theme, against mocked API
responses only (no real Fineract backend), with no checker on any row.
Confirmed the two columns are hidden, the search narrows the rows, the Filters
bar aligns and Result renders as a pill.
- Not run: the full unit suite, the production build and the Playwright
specs.
## Screenshots
<!-- Add screenshots or a short recording for UI changes. Write "Not
applicable" for non-UI changes. -->
### Before
<img width="1440" height="900" alt="before-audit-logs-full"
src="https://github.com/user-attachments/assets/01dd4d4e-83f0-4247-8d6b-9b62c89b842a";
/>
https://github.com/user-attachments/assets/06e1984b-1cd9-4c07-b904-d410d1305a30
### After
<img width="1440" height="900" alt="after-audit-logs-full"
src="https://github.com/user-attachments/assets/511dc2fc-34a2-42b6-bb8e-9cc7f0df51be";
/>
<img width="1440" height="900" alt="after-audit-logs-search"
src="https://github.com/user-attachments/assets/91e59906-0bc4-4622-94f0-864194c2b505";
/>
https://github.com/user-attachments/assets/f155672f-d7e0-4364-9f3e-b4aac2609fff
## AI assistance (optional)
<!-- If generative AI materially assisted this contribution, optionally
state the tool or model and
the harness or workflow used. The contributor remains responsible for the
submitted change. -->
- Tool / model:
- Harness / workflow:
## Checklist
<!-- Check each item, or explain why it does not apply. -->
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [x] User-facing strings use translation keys. (No new strings; the search
box uses the existing keys.)
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [ ] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant. (No e2e spec added; covered by unit tests
and a manual mocked run.)
- [ ] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
- [ ] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
