Samer-Melhem-FOO opened a new pull request, #6525: URL: https://github.com/apache/fineract/pull/6525
## Description [FINERACT-2862](https://issues.apache.org/jira/browse/FINERACT-2862) `SearchUtil.parseColumnValue` parses the value of a code lookup (dropdown) datatable column with a bare `Integer.valueOf(columnValue)`. That branch is only taken once the column's code has at least one code value, and there a non-numeric value throws an uncaught `NumberFormatException`, so the request fails with HTTP 500 and no validation details. This affects `POST /datatables/{datatable}/{apptableId}` and client creation with an embedded `datatables` entry, and the same method also parses datatable query filter values. The fix catches the `NumberFormatException` and raises the same `error.msg.invalid.columnValue` ("Value not found in Allowed Value list") validation error that the check right below already returns for a numeric id outside the code's values. **Tests** - New `SearchUtilTest` (fineract-core) for a code lookup column: an allowed id is returned as an `Integer`, an id outside the list and a non-numeric value both raise `PlatformApiDataValidationException` with `error.msg.invalid.columnValue`. Without the fix the non-numeric case fails with `NumberFormatException`; with it all three pass. - Checked manually on a local `develop` build (PostgreSQL): with a code that has one value and a client datatable with a dropdown column on it, `POST /datatables/{datatable}/{clientId}` with `"abc"` returned HTTP 500 before the change and HTTP 400 `error.msg.invalid.columnValue` after it; `POST /clients` with the same value in an embedded `datatables` entry went from 500 to 400. An unknown numeric id still returns 400 and a valid id is still saved and read back. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
