Samer-Melhem-FOO opened a new pull request, #6529: URL: https://github.com/apache/fineract/pull/6529
## Description JIRA: https://issues.apache.org/jira/browse/FINERACT-2866 A user-created report could not be deleted in two situations: - **After a rename.** `updateReport` changed `reportName` but left the companion `READ_<oldName>` permission untouched, so `deleteReport` later looked up `READ_<newName>` and failed with `PermissionNotFoundException` (404). - **After its READ permission was granted to a role.** `deleteReport` deleted the permission directly. `m_role_permission` is only maintained from the owning `Role` side, so the delete violated the `m_role_permission` → `m_permission` foreign key (403, data integrity). Fix: - `Permission.updateEntityName(String)`: `updateReport` renames the matching `READ_` permission when `reportName` changes. - `deleteReport` logs a warning and still deletes the report when no matching permission exists, so reports renamed before this fix can be cleaned up. - `RoleRepository.findByPermissionId(Long)`: `deleteReport` removes the permission from every role holding it before deleting the permission. `ReportWritePlatformServiceImpl` gets a new constructor argument (`RoleRepository`). **Interplay with #6521 (FINERACT-2860):** that PR touches only `assembleSetOfReportParameterUsages` in the same class, so the main-code hunks don't overlap. But its new `ReportWritePlatformServiceImplTest` calls the current 7-argument constructor. Whichever of the two PRs merges second needs that test call updated to pass a `RoleRepository` mock. I'll rebase this PR if #6521 lands first. **Tests** - New `ReportWritePlatformServiceImplPermissionTest`: 4 tests covering rename, update without rename, delete with no permission, and delete with a role grant. All pass; on `develop` the test does not compile. - Live check with `bootRun` against PostgreSQL: - On unmodified `develop`, rename then delete returned 404 "Permission with Code READ_<new name> does not exist", and grant to a role then delete returned 403 on `fk8dedb048103b544b`. The report stayed in both cases. - With the fix, both deletes return 200. The permission is renamed on rename, and the role's grant and the permission are removed on delete. Reports left in either state by the unmodified run were also deleted successfully. No API change. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
