rymghosn opened a new pull request, #6540: URL: https://github.com/apache/fineract/pull/6540
## Description JIRA: [FINERACT-2876](https://issues.apache.org/jira/browse/FINERACT-2876) `GET /standinginstructions/template` returns none of the option lists the "Create Standing Instruction" screen needs, so every dropdown on it is empty (Type, Priority, Status, From/To Office, From/To Account Type, Standing Instruction Type, Recurrence Type, Recurrence Frequency). `GET /standinginstructions/{id}` also leaves out `fromOffice` and `toOffice`. **Root cause:** `StandingInstructionData` is returned directly from `StandingInstructionApiResource` and serialized by the platform `ObjectMapper`, which uses Jackson's default visibility, so a private field is only serialized if it has a getter. FINERACT-2490 and FINERACT-2723 added `@Getter` to the value fields, but `fromOffice`, `toOffice` and the 14 `*Options` collections still have none, and Jackson drops them without any error. **Fix:** add `@Getter` to those 16 fields. No hand-written getter with these names exists, so nothing conflicts. **Tests:** `StandingInstructionDataSerializationTest` gets two new tests: every `*Options` list of a populated `template(...)` is serialized, and `fromOffice`/`toOffice` are serialized for an instance. Both fail on current `develop` and pass with the fix; `spotlessJavaCheck` is clean. **Live check** (local `bootRun` on a stock PostgreSQL schema, `GET /v1/standinginstructions/template?fromAccountType=2&fromOfficeId=1`): - before: HTTP 200 with only `fromAccountType`, `fromAccountTypeEnum`, `recurrenceOnDay` and `recurrenceOnMonth`, no `*Options` key at all - after: HTTP 200 with `fromOfficeOptions`, `fromClientOptions`, `fromAccountTypeOptions`, `toOfficeOptions`, `toAccountTypeOptions`, `transferTypeOptions`, `statusOptions`, `instructionTypeOptions`, `priorityOptions`, `recurrenceTypeOptions`, `recurrenceFrequencyOptions` and `fromOffice`; adding `fromClientId` and `toOfficeId` also returns `toClientOptions`, `fromAccountOptions` and `toOffice` ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change: the response now carries the fields it was always meant to) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
