shivaansh0610-LUFFY commented on issue #326: URL: https://github.com/apache/fineract-backoffice-ui/issues/326#issuecomment-5917345586
Hi @Aman-Mittal, I’ve implemented the in-context creation flow for #326 and wanted to confirm the intended scope before opening the PR. I deliberately avoided another small quick-create dialog because #543 was reverted in #554 for having only a limited set of hard-coded fields. The implementation here instead opens the existing full product form in a dialog, so it keeps the same product options and validation as the normal product page. The current implementation: * supports loan, savings, fixed deposit, recurring deposit, and share applications * shows a create action in the zero-state when the product list is empty * also supports the existing `+` action * reloads the list and selects the newly created product while preserving the rest of the application form * supports creating a GL account directly from the product form when an account class has no GL accounts * prevents accidental dismissal of the long forms via backdrop click or Escape I’ve intentionally left Payment Type and charges optional, since they are not required to create the product in these flows. Because the change is fairly large, I’m planning to split it into three reviewable PRs: 1. shared in-context creation pieces + loan application flow 2. savings / fixed deposit / recurring deposit / share flows 3. GL account creation from the product form Does this scope and the use of the real product form in a dialog look reasonable before I open the PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
