shivaansh0610-LUFFY commented on PR #643: URL: https://github.com/apache/fineract-backoffice-ui/pull/643#issuecomment-5927745787
Thanks @Aman-Mittal. I added e2e coverage in 7bdb3caf and it's green in CI, including the real-Fineract shards: oidc-login.spec.ts (mocked): no button when the flag is absent or off, button above the form with the form still usable, the "not available yet" notice that goes nowhere, password sign-in still works, and no button during the second-factor step. oidc-login-backend.spec.ts (real Fineract): the button appears beside the form and pressing it sends nothing to Fineract, and a real password sign-in still works with the button shown. I haven't added a dedicated job like the two-factor one. That job exists because 2FA is a process-wide Fineract switch. This PR doesn't touch Fineract's OIDC yet, so a stack with an identity provider would have nothing to exercise. I'd add it, with Keycloak and oidc-federation.enabled, in the PR that implements the PKCE flow. Is that OK, or would you rather have the dedicated stack in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
