[
https://issues.apache.org/jira/browse/FINERACT-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna Mewara updated FINERACT-2883:
-------------------------------------
Description:
Part of FINERACT-2609, continuing FINERACT-2746. Moves the rest of the
organisation, configuration, jobs and admin integration tests from REST Assured
and the Retrofit client to the generated Feign client. This finishes roadmap
row 13.
Done in two PRs:
PR #6559 (row 13): 24 classes, 131 tests. Users and roles, staff, funds and
payment types, business and
PR #6561 (row 13b, stacked on #6559): 7 classes, 42 tests.
CashierSummaryAndTransactionsTest, AllocateCashToCashierValidationTest,
EmailTest, CreditBureauConfigurationValidationTest,
CreditBureauConfigurationTest, CreditBureauTest and SchedulerJobsTestResults.
These needed spec fixes first: teller status, email and credit bureau schemas,
and loan isNPA.
Both PRs only fix the OpenAPI spec where it did not match what the server reads
or returns. There is no runtime change. Legacy helpers left without callers are
removed, along with their restassured-baseline.xml entries.
Found along the way, for separate tickets: creating a cashier does not return
the new cashier's id, and PUT /tellers rejects the enum status the spec
documents.
was:
continuing FINERACT-2746. Migrates the remaining organisation, configuration,
jobs and administration integration tests from REST-assured to the generated
Feign client.
PR #6558 covers 24 classes (131 tests): users and roles, staff, funds and
payment types, business and external service configuration, scheduler jobs,
templates, campaigns and SMS, audit and IP tracking, codes, account number
preferences, search, batch requests, datatables and maker checker.
The OpenAPI spec is corrected where it did not describe what the server reads
or returns (13 fixes, listed in the PR). There is no runtime change. The legacy
helpers left without callers are removed, along with their
restassured-baseline.xml entries.
A follow-up PR covers CashierSummaryAndTransactionsTest,
AllocateCashToCashierValidationTest, EmailTest,
CreditBureauConfigurationValidationTest and SchedulerJobsTestResults, together
with the Swagger fixes they need (teller status, email request and response
schemas, credit bureau annotations).
> Migrate the user, configuration, job and datatable integration tests to the
> Feign client
> ----------------------------------------------------------------------------------------
>
> Key: FINERACT-2883
> URL: https://issues.apache.org/jira/browse/FINERACT-2883
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Affects Versions: 1.15.0
> Reporter: Krishna Mewara
> Assignee: Krishna Mewara
> Priority: Trivial
> Labels: beginner-friendly, feign-migration
> Fix For: 1.16.0
>
>
> Part of FINERACT-2609, continuing FINERACT-2746. Moves the rest of the
> organisation, configuration, jobs and admin integration tests from REST
> Assured and the Retrofit client to the generated Feign client. This finishes
> roadmap row 13.
>
> Done in two PRs:
>
> PR #6559 (row 13): 24 classes, 131 tests. Users and roles, staff, funds and
> payment types, business and
>
> PR #6561 (row 13b, stacked on #6559): 7 classes, 42 tests.
> CashierSummaryAndTransactionsTest, AllocateCashToCashierValidationTest,
> EmailTest, CreditBureauConfigurationValidationTest,
> CreditBureauConfigurationTest, CreditBureauTest and SchedulerJobsTestResults.
> These needed spec fixes first: teller status, email and credit bureau
> schemas, and loan isNPA.
>
> Both PRs only fix the OpenAPI spec where it did not match what the server
> reads or returns. There is no runtime change. Legacy helpers left without
> callers are removed, along with their restassured-baseline.xml entries.
>
> Found along the way, for separate tickets: creating a cashier does not return
> the new cashier's id, and PUT /tellers rejects the enum status the spec
> documents.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
