Aman-Mittal opened a new pull request, #694:
URL: https://github.com/apache/fineract-backoffice-ui/pull/694
One line. `APIRequestContext` was left over from a first draft of
`e2e/loan-flows-non-admin-roles.spec.ts` that took an API context as a
parameter; `platformAllows()` creates and disposes its own, so the type was
never used.
Missed in #692 because `e2e/` is outside the lint scope — CI runs `eslint
src` and `eslint "src/**/*.html"` — so nothing flags it. Found by running
eslint on the file directly.
Worth saying what I deliberately did **not** change while I was there.
Running eslint on that file also reports two stylistic errors and one warning,
all of which match the surrounding e2e code rather than departing from it:
| Reported | Also in |
| --- | --- |
| `unicorn/prefer-split-limit` on `clientName.split(' ')[0]` |
`loan-lifecycle.spec.ts:125`, identical line |
| `unicorn/prefer-at` on the password generator |
`e2e/utils/seed-api.ts:1040`, where the helper was copied from |
| `security/detect-non-literal-regexp` on a URL assertion |
`loan-lifecycle.spec.ts:196`, same construction |
`seed-api.ts` alone reports 25 problems against these rules. Fixing three of
them in one spec would make that file the odd one out without moving the
project anywhere, so this PR removes the dead code and leaves the style
questions to whoever decides whether `e2e/` should be linted at all — which is
a real question, just not this one.
`tsc -p tsconfig.e2e.json` and `prettier --check` clean. The spec still
passes 9/9 against the local stack; the full suite was 541 passed / 1 skipped /
0 failed on the commit this rebases onto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
