alberto-art3ch opened a new pull request, #6568: URL: https://github.com/apache/fineract/pull/6568
## Description Disabling a transaction type's external event (e.g. `LoanReAgeTransactionBusinessEvent`) did not suppress the generic `LoanAdjustTransactionBusinessEvent` raised for that transaction during a reverse-replay, so the adjustment still reached consumers inside a `BulkBusinessEvent`. Adds a `DependentExternalEvent` contract in fineract-core: the notifier now posts such an event externally only when both its own type and the governing transaction-type event are enabled; `LoanAdjustTransactionBusinessEvent` and `WorkingCapitalLoanAdjustTransactionBusinessEvent` implement it through per-module `LoanTransactionType` → event maps, covering Term Loan, Progressive and Working Capital with no changes at the emitters and without affecting internal listeners. Includes unit tests for the gate and both maps, integration tests for the re-age replay (PL) and the discount fee amortization reversal (WC), and documents the rule in the reliable event framework chapter. [FINERACT-2684](https://issues.apache.org/jira/browse/FINERACT-2684) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
