rk-roshan-kr opened a new pull request, #703: URL: https://github.com/apache/fineract-backoffice-ui/pull/703
<!-- Commits must be signed to merge — see CONTRIBUTING.md#commit-signing if you haven't set this up. --> ## What and why When navigating away from a record view while an Actions or Create popover menu is open, the overlay remained mounted in the DOM overlay stack because `IonPopover` from `@ionic/angular/standalone` lacks an `ngOnDestroy` lifecycle handler. This left a dead Actions menu floating over subsequent screens. Instead of intercepting global router events (which previously broke date pickers and overlay interactions in PR #589), this change queries `IonPopover` instances with `viewChildren` on each record view component and dismisses them during `ngOnDestroy`. Closes #586 ## Verification - `npm run lint`: Passed with 0 errors and 0 warnings. - `npm test`: Passed all 292 test files (2,018 unit tests passed). - Added teardown unit tests across all 8 record view components verifying `dismiss()` is invoked upon fixture destruction. - `npm run build`: Production AOT compilation and chunk bundling succeeded without errors. ## Screenshots Not applicable. ## AI assistance (optional) - Tool / model: Google Antigravity - Harness / workflow: Pair programming via Antigravity IDE ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. - [x] I followed the [AI-assisted contributions guidance](CONTRIBUTING.md#ai-assisted-contributions). - [x] If this adds a feature or changes a workflow, I raised it on [[email protected]](mailto:[email protected]) first — or it is a bug fix, refactor or test change, where that does not apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
