shivaansh0610-LUFFY opened a new pull request, #709:
URL: https://github.com/apache/fineract-backoffice-ui/pull/709
## What and why
Closes #292.
#292 describes two problems in the fixed and recurring deposit product
forms. The data-loss part is already fixed on `main` by #309: editing a product
used to submit a fabricated deposit amount, accounting rule NONE, and an
invented rate chart. This PR adds the regression coverage #292 asks for, so the
fix can't quietly regress.
Changing only a product's name should send back everything else unchanged.
The new tests assert on the `PUT` payload rather than the rendered form,
because the form looks the same whether the right or wrong values were
submitted.
## Changes
- Adds `e2e/deposit-product-edit.spec.ts`, a mocked Playwright spec in the
`mocked` project, with two tests:
- **Fixed deposit product:** a name-only edit keeps the deposit amount,
the accounting rule, the six cash-based GL mappings, and the existing rate
chart (chart id, slab id and rate).
- **Recurring deposit product:** the same checks, plus the recurrence
fields.
- No application code changes.
## Verification
- Against current `main`: both tests pass (`npx playwright test
--project=mocked e2e/deposit-product-edit.spec.ts`).
- Against the commit before #309: both tests fail, and the bug is visible in
the payload. Fixed: `depositAmount: 1000`, `accountingRule: 1`, no mappings,
and a 5% chart with no ids. Recurring: the same pattern, plus the recurrence
fields missing.
- `prettier --check` and `tsc -p tsconfig.e2e.json --noEmit` pass.
- Not run: the real-backend specs, which need the Docker stack.
`deposit-product-configuration.spec.ts` already covers the fixed-deposit edit
against Fineract. Unit tests and lint were not run because there are no `src/`
changes.
## Screenshots
Not applicable. This PR changes tests only, not the UI.
## AI assistance (optional)
- Tool / model:
- Harness / workflow:
## Checklist
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] Adapter boundary: N/A, no component or service code was added.
- [x] Translation keys: N/A, no user-facing strings were added.
- [x] Tests added or updated.
- [x] UI workflow coverage: mocked Playwright regression tests; real-backend
coverage already exists in `deposit-product-configuration.spec.ts`.
- [ ] Commits are signed.
- [ ] AI-assisted contributions guidance followed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
