rymghosn commented on PR #6290: URL: https://github.com/apache/fineract/pull/6290#issuecomment-5992455512
@adamsaghy Thanks, I've added `TaxGroupComponentStartDateTest` and rebased on the latest `develop`. It covers both sides of the rule: - a component whose start date is still in the future can have its start date moved, and the new date is stored on the same mapping; - a component that has already taken effect is rejected with `cannot.be.modified.after.activation`, and its start date is unchanged. Both fail on `develop` and pass with this PR. To reach this path over REST, the PR also carries the `id`/`endDate` fields on `TaxGroupComponent` from #6291 (an identical hunk, so they merge cleanly in either order). The swagger now also declares the `modifiedComponents` dates of the update response as dates, which is what the endpoint returns. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
